Handle images in roolease notes #7548
Conversation
dosubot
bot
added
size:XS
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for your contribution! I've reviewed the changes and the implementation looks good overall. The feature to convert relative image paths to GitHub raw URLs in release notes is useful and well-implemented. I've left a few suggestions inline that could improve the robustness and flexibility of the solution.
| # Convert relative image paths to full GitHub URLs for proper display in release notes | ||
| # Use the main branch URL since the images will be merged there before release | ||
| # Only match .png files to avoid accidentally modifying other references | ||
| changelog_content=$(echo "$changelog_content" | sed "s|(releases/\([^)]*\.png\))|(https://github.com/${{ github.repository }}/raw/main/releases/\1)|g") |
There was a problem hiding this comment.
Consider supporting more image formats beyond just PNG. You could modify this to:
This would handle .jpg, .jpeg, .gif, and .svg files as well.
There was a problem hiding this comment.
@roomote-agent good point, make it handle those types too
| # Convert relative image paths to full GitHub URLs for proper display in release notes | ||
| # Use the main branch URL since the images will be merged there before release | ||
| # Only match .png files to avoid accidentally modifying other references | ||
| changelog_content=$(echo "$changelog_content" | sed "s|(releases/\([^)]*\.png\))|(https://github.com/${{ github.repository }}/raw/main/releases/\1)|g") |
There was a problem hiding this comment.
Is the hardcoded 'main' branch assumption always valid? If a release is created from a different branch or tag, the images might not be accessible. Could we use the actual release tag or branch instead?
For example, you could use:
This would reference the images from the release tag itself.
hannesrudolph
added
the
Issue/PR - Triage
|
On it! I'll update the workflow to handle additional image formats (jpg, jpeg, gif, svg) as suggested. Working on the changes now. |
|
I've updated the workflow to support multiple image formats (jpg, jpeg, gif, svg) in addition to png. The change modifies line 87 in Change made: - changelog_content=$(echo "$changelog_content" | sed "s|(releases/\([^)]*\.png\))|(https://github.com/${{ github.repository }}/raw/main/releases/\1)|g")
+ changelog_content=$(echo "$changelog_content" | sed "s|(releases/\([^)]*\.\(png\|jpg\|jpeg\|gif\|svg\)\))|(https://github.com/${{ github.repository }}/raw/main/releases/\1)|g")However, I encountered a permission issue when trying to push the changes - the GitHub App doesn't have
The implementation is ready and all tests pass successfully! |
daniel-lxs
moved this from PR [Needs Prelim Review]
to PR [Needs Review]
in Roo Code Roadmap
hannesrudolph
added
PR - Needs Preliminary Review
PR - Needs Review
and removed
Issue/PR - Triage
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
Important
Converts relative image paths in release notes to full GitHub URLs in
marketplace-publish.ymland updatesrelease.mddocumentation.marketplace-publish.yml, converts relative image paths in changelog to full GitHub URLs for PNG, JPG, JPEG, GIF, WEBP, and SVG files.release.mdto mention conversion of PNG image paths to GitHub raw URLs in release notes.This description was created by
for f8051e8. You can customize this summary. It will automatically update as commits are pushed.